ACMS-1900: Supporting environment variable with NO value.

acquia · Sep 19, 2023 · 157fab2 · 157fab2
1 parent 44fbd56
commit 157fab2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/Helpers/InstallerQuestions.php b/src/Helpers/InstallerQuestions.php
@@ -131,7 +131,8 @@ public function getDefaultValue(array $question, string $key = ""): string {
    *   Returns the default value for question.
    */
   public function getEnvValue(array $question, string $key = ""): string {
-    return trim(PHPParser::parseEnvVars(!empty(getenv($key)) ? getenv($key) : ''));
+    $env = getenv(str_replace("-", "_", strtoupper($key)));
+    return trim(PHPParser::parseEnvVars(!empty($env) ? $env : ''));
   }
 
   /**

diff --git a/tests/unit/Helpers/InstallerQuestionsTest.php b/tests/unit/Helpers/InstallerQuestionsTest.php
@@ -220,15 +220,15 @@ public function providerDefaultValue(): array {
         'some_value',
         'sitestudio-api-key',
         [
-          'sitestudio-api-key' => 'some_value',
+          'SITESTUDIO_API_KEY' => 'some_value',
         ],
       ],
       [
         CliTest::getGmapsKey()['gmaps-key'],
-        '',
+        'some_value',
         'gmaps-key',
         [
-          'SOME_RANDOM_VALUE' => 'some_value',
+          'GMAPS_KEY' => 'some_value',
         ],
       ],
     ];