Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild the nix flake; drop htoml dependency #173

Merged
merged 9 commits into from
Oct 22, 2023
Merged

Rebuild the nix flake; drop htoml dependency #173

merged 9 commits into from
Oct 22, 2023

Conversation

acowley
Copy link
Owner

@acowley acowley commented Apr 30, 2023

Significantly simplified nix flake setup.

Replaced the htoml dependency in the spec test with tomland.

Fixes #172

@acowley
Copy link
Owner Author

acowley commented Apr 30, 2023

Any thoughts on this @idontgetoutmuch? I took out a lot from the flake, perhaps too much, but I really wanted it to work with cached packages.

Significantly simplified nix flake setup.

Replaced the `htoml` dependency in the spec test with `tomland`.
@idontgetoutmuch
Copy link

Any thoughts on this @idontgetoutmuch? I took out a lot from the flake, perhaps too much, but I really wanted it to work with cached packages.

Thanks very much for doing this :-)

I don't count myself as able to comment on nix. I don't use flakes (I know I ought to). I assume you were trying to test with previous version of ghc as well as the "current" one. I don't understand the user base of Frames well enough to know whether this is worth it.

@MMesch
Copy link

MMesch commented Jun 15, 2023

Hey, this is nice. Would be good to have frames available in upstream nixpkgs again.

@acowley acowley merged commit c7d62e9 into master Oct 22, 2023
8 checks passed
@acowley acowley deleted the replace-htoml branch October 22, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frames fails to install via nix
3 participants