Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

fix: allow traefik external names in ingress #2461

Merged
merged 1 commit into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/install/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ func Install(ctx context.Context, image string, opts *Options) error {
s.Success()

if installIngressController {
if err := installTraefik(ctx, opts.Progress, c, apply); err != nil {
if err := installTraefik(ctx, opts.Progress, apply); err != nil {
return err
}
}
Expand Down Expand Up @@ -419,7 +419,7 @@ func missingIngressClass(ctx context.Context, client kclient.Client) (bool, erro
return len(ingressClassList.Items) <= 0, nil
}

func installTraefik(ctx context.Context, p progress.Builder, client kclient.WithWatch, apply apply.Apply) (err error) {
func installTraefik(ctx context.Context, p progress.Builder, apply apply.Apply) (err error) {
pb := p.New("Installing Traefik Ingress Controller")
defer func() {
_ = pb.Fail(err)
Expand Down
1 change: 1 addition & 0 deletions pkg/install/traefik.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ spec:
- "--metrics.prometheus.entrypoint=metrics"
- "--providers.kubernetesingress"
- "--providers.kubernetesingress.ingressendpoint.publishedservice=acorn-system/traefik"
- "--providers.kubernetesingress.allowexternalnameservices=true"
- "--entrypoints.websecure.http.tls=true"
volumes:
- name: data
Expand Down
Loading