This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
fix: address issue with computeclass tables not converting properly #2438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
acorn offerings computeclasses
andkubectl get clustercomputeclasses
would fail with the following error:This was due to a recent change where the
Memory
struct onapiv1.ComputeClass
andadminv1.ClusterComputeClass
are now different. The fix is to check for both types and process them accordingly when converting values into a table.Checklist
This is a title (#1216)
. Here's an example