This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
fix: replace / with - in anonymous ephemeral volume names (manager-specific) (manager#1598) #2362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirs: "/foo/bar": "ephemeral://"
stores a volume with name/foo/bar
, which is OK in runtime, but is actually used as a resource name in Manager, which cannot contain/
, so we're replacing this here (instead of adapting the store strategy in Manager)I'm not sure if we'll need more sophisticated replaces here to make it a DNS name 🤔
Discovered as part of #1598
Checklist
This is a title (#1216)
. Here's an example