Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

fix: replace / with - in anonymous ephemeral volume names (manager-specific) (manager#1598) #2362

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Nov 23, 2023

dirs: "/foo/bar": "ephemeral://" stores a volume with name /foo/bar, which is OK in runtime, but is actually used as a resource name in Manager, which cannot contain /, so we're replacing this here (instead of adapting the store strategy in Manager)

I'm not sure if we'll need more sophisticated replaces here to make it a DNS name 🤔

Discovered as part of #1598

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Copy link
Contributor

@g-linville g-linville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but how badly will this disrupt existing volumes with / in the name from the user's perspective?

@iwilltry42
Copy link
Contributor Author

@g-linville this only affects ephemeral:// (no name given) auto-generated volume names, so the impact will probably be fairly low, especially since they apparently didn't work in Manager so far.

@iwilltry42 iwilltry42 merged commit 01cbfd5 into acorn-io:main Dec 6, 2023
4 checks passed
@iwilltry42 iwilltry42 deleted the issue/manager-1598 branch December 6, 2023 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants