This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Add feature flag to control whether we should add don't evict annotation #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
flip-karpenter-annotation
branch
from
ae63210 to
cfdb8a1
Compare
StrongMonkey
requested review from
thedadams,
njhale,
keyallis,
g-linville,
tylerslaton and
iwilltry42
g-linville
approved these changes
Dec 5, 2023
tylerslaton
approved these changes
Dec 5, 2023
thedadams
approved these changes
Dec 5, 2023
| @@ -73,5 +73,6 @@ func defaultProfile() apiv1.Config { | |||
| ControllerCPU: new(string), | |||
| APIServerMemory: new(string), | |||
| APIServerCPU: new(string), | |||
| AutoConfigureKarpenterDontEvictAnnotations: z.Pointer(true), | |||
There was a problem hiding this comment.
Nope, still give me the same ouput 🤷♂️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This is a title (#1216). Here's an exampleWe should add runtime configuration to control whether we should add karpenter do-not-evict annotation for any deploy that has 1 replica. Ideally, we should only add the annotation when cluster is in production use. For dev purpose, it is better to not have the annotation so that these apps/nodes can be consolidated.