Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Wait for server to acknowledge app deletion before trying ignore-cleanup #2324

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

thedadams
Copy link
Contributor

There are certain situations where the app delete succeeds and the call to ignore-cleanup fails because it thinks that the app is not being deleted. This change will retry on this error to avoid the necessity of having to delete the app and then ignore-cleanup.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Issue: https://github.com/acorn-io/manager/issues/1585

There are certain situations where the app delete succeeds and the call
to ignore-cleanup fails because it thinks that the app is not being
deleted. This change will retry on this error to avoid the necessity of
having to delete the app and then ignore-cleanup.

Signed-off-by: Donnie Adams <[email protected]>
@thedadams thedadams merged commit 6b3a745 into acorn-io:main Nov 9, 2023
4 checks passed
@thedadams thedadams deleted the gh-m1585 branch November 9, 2023 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants