Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

change: block devsessions if IAR is enabled (#2180) #2314

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Nov 2, 2023

Ref #2180

I couldn't find an elegant way to error out before the build, so unfortunately that's still there, but the error message is a lot clearer now.

User will be shown

# ... build output ...
INFO[0003] Updating acorn [foo] to image [7741793d354ecdf8936671fda9e940b832d6501b002c08e83ae749896d6047da] 
  ✗  ERROR:  ImageAllowRules active - DevSessions are being blocked

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@iwilltry42 iwilltry42 changed the title change: block devsessions if IAR is enabled change: block devsessions if IAR is enabled (#2180) Nov 2, 2023
@iwilltry42 iwilltry42 merged commit 39e8aed into acorn-io:main Nov 3, 2023
4 checks passed
@iwilltry42 iwilltry42 deleted the iwilltry42/issue2180 branch November 3, 2023 04:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants