Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

fix: properly handle image-not-allowed errors for normal tags and autoupgrade patterns (#1698 + #1970 + #1409) #1984

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Jul 26, 2023

Ref #1968 + #1970 + #1409

Fixes 2 ways for the CLI to panic when running an app against an IAR enabled setup.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@iwilltry42 iwilltry42 requested review from thedadams, g-linville, njhale and keyallis and removed request for thedadams and g-linville July 26, 2023 15:16
@iwilltry42 iwilltry42 changed the title fix: properly handle image-not-allowed errors for normal tags and autoupgrade patterns (#1698 + #1970) fix: properly handle image-not-allowed errors for normal tags and autoupgrade patterns (#1698 + #1970 + #1409) Jul 26, 2023
@iwilltry42 iwilltry42 merged commit e207b5e into acorn-io:main Jul 28, 2023
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
…oupgrade patterns (acorn-io#1698 + acorn-io#1970 + acorn-io#1409) (acorn-io#1984)

* fix: properly handle image-not-allowed errors for normal tags and autoupgrade patterns

Signed-off-by: Thorsten Klein <[email protected]>

* change: more precise error message if image fails verification due to missing signature

Signed-off-by: Thorsten Klein <[email protected]>

---------

Signed-off-by: Thorsten Klein <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants