This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Fix volume class determination when binding an existing volume #1966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug while troubleshooting one of our failing tests.
Prior to this PR, if the volume class is not determined as part of the
-v
argument inacorn run
, it would be assumed based on the label on the existing PV, and then that label would be set on the new PVC that binds the PV. However, the code fails to properly set thestorageClassName
spec field on the PVC, and it takes the default storage class, leading to a possible mismatch and the inability to actually bind the volume. This change makes sure that the storage class is set based on the volume class under all circumstances.Checklist
This is a title (#1216)
. Here's an example(Our e2e tests cover this.)