Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Add an init function for logserver #1943

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

g-linville
Copy link
Contributor

This allows consumers of this package to import it and do nothing else. Darren requested this.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ergonomic!

Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville requested a review from tylerslaton July 17, 2023 20:59
Copy link
Contributor

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@g-linville g-linville merged commit 7b1a325 into acorn-io:main Jul 18, 2023
@g-linville g-linville deleted the logserver-init branch July 18, 2023 00:50
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants