Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Use credentials when checking to see if an image is remote #1923

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

g-linville
Copy link
Contributor

@g-linville g-linville commented Jul 12, 2023

I totally forgot to add this when I first implemented this change.
This should fix the failing e2e test called TestExtRegAutoUpgradeOptionWithPull. I believe it will also fix TestExtRegAutoUpgradeOptionWithLocalImage.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@g-linville g-linville changed the title Use credentials correctly when checking to see if an image is remote Use credential when checking to see if an image is remote Jul 12, 2023
@g-linville g-linville changed the title Use credential when checking to see if an image is remote Use credentials when checking to see if an image is remote Jul 12, 2023
@g-linville g-linville merged commit c8f3d59 into acorn-io:main Jul 12, 2023
@g-linville g-linville deleted the pull-fix branch July 12, 2023 20:17
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants