This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Allow acorn rm --ignore-cleanup
on services (#1795)
#1878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1795
We recently added the
--ignore-cleanup
flag toacorn rm
, which removes some finalizers and ignores thedelete
event job(s). This was not working for services (and probably wasn't working for nested Acorns either), since the default name validation was blocking names with.
, and the logic to find the AppInstance was not checking the public name label. This PR fixes both of those things.To validate my changes, I am using the following Acornfiles:
When deploying this app, it is never ready (thanks to the bad container in the service). When you delete the app, it looks like it succeeds in the CLI, but that kicks off the delete job in the service, which fails continuously. Previously,
acorn rm --ignore-cleanup <app name>.myservice
would fail, but now it works and finishes cleaning everything up.Checklist
This is a title (#1216)
. Here's an example