This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Rename event severity warn to error and rm critical #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor event severity such that only two levels remain: 1. "info" 2. "error" This means removing the unused "critical" severity and renaming "warn" to "error". Signed-off-by: Nick Hale <[email protected]>
njhale
requested review from
thedadams,
StrongMonkey,
g-linville and
tylerslaton
g-linville
approved these changes
Jun 29, 2023
tylerslaton
reviewed
Jun 29, 2023
Co-authored-by: Tyler Slaton <[email protected]> Signed-off-by: Nick Hale <[email protected]>
tylerslaton
approved these changes
Jun 29, 2023
g-linville
approved these changes
Jun 29, 2023
StrongMonkey
approved these changes
Jun 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor event severity such that only two levels remain:
This means removing the unused "critical" severity and renaming "warn"
to "error".
Signed-off-by: Nick Hale [email protected]