auto-upgrade not outputted as part of acorn run -o yaml

[cjellick]

No description provided.

[tylerslaton]

Gave this a look and this isn't a direct result of adding -o, auto-upgrade actually something that isn't set on the spec unless explicitly specified by the user. The daemon for auto-upgrade then makes assumptions based on what subset of those values are present.

For example, if you run an app without the -o, it will also have the auto-upgrade spec value not set but you will still get auto-upgrades. So the options I see are:

1. Move the daemon's "assumption" logic into run.go so that all apps that will be ran with auto-upgrade will have that field set regardless if it is explicitly set by the user.
2. Leave it the same and have consumers of -o yaml do that "assumption" logic.

For reference what I'm calling the "assumption logic" can be found here.

Thoughts @cjellick?

[cjellick]

Pretty sure I want to change this behavior. I think this also affects the UI. Like, @vincent99 may not know to mark an app as autoupgrade if that flag isnt set.

I think the behavior I want is that the autoUpgrade field must be set, but the CLI helps - if the tag is detected to be a pattern, set the autoUpgrade field for the user. This should be done client side, not server side.

[tylerslaton]

The backend code for this has been set in place. Now the UI just needs to read from AppInstance.Status.ObservedAutoUpgrade in order to properly display when auto-upgrade is enabled.