Remove custom event name validation

Allow clients to set custom event names by removing validation expecting them to content hashes. This help make event PUT|POST more easily curl-able. Signed-off-by: Nick Hale <[email protected]>
acorn-io · Jul 12, 2023 · 5a4a090 · 5a4a090
1 parent f39d170
commit 5a4a090
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 38 deletions.
diff --git a/pkg/event/event.go b/pkg/event/event.go
@@ -35,7 +35,6 @@ func NewRecorder(c kclient.Client) RecorderFunc {
 		}
 
 		// Set a generated name based on the event content.
-		// NOTE: This is validated server-side, so it's important that this is done, just before sending the request.
 		id, err := ContentID(e)
 		if err != nil {
 			return fmt.Errorf("failed to generate event name from content: %w", err)

diff --git a/pkg/server/registry/apigroups/acorn/events/storage.go b/pkg/server/registry/apigroups/acorn/events/storage.go
@@ -23,7 +23,6 @@ func NewStorage(c kclient.WithWatch) rest.Storage {
 
 	return stores.NewBuilder(c.Scheme(), &apiv1.Event{}).
 		WithTableConverter(tables.EventConverter).
-		WithValidateName(new(validator)).
 		WithCompleteCRUD(strategy).
 		Build()
 }
diff --git a/pkg/server/registry/apigroups/acorn/events/validator.go b/pkg/server/registry/apigroups/acorn/events/validator.go