Merge pull request #2461 from thedadams/traefik-external-names

fix: allow traefik external names in ingress
acorn-io · Jan 26, 2024 · 177abfe · 177abfe
2 parents ce008ae + 7be0a0f
commit 177abfe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/install/install.go b/pkg/install/install.go
@@ -270,7 +270,7 @@ func Install(ctx context.Context, image string, opts *Options) error {
 	s.Success()
 
 	if installIngressController {
-		if err := installTraefik(ctx, opts.Progress, c, apply); err != nil {
+		if err := installTraefik(ctx, opts.Progress, apply); err != nil {
 			return err
 		}
 	}
@@ -419,7 +419,7 @@ func missingIngressClass(ctx context.Context, client kclient.Client) (bool, erro
 	return len(ingressClassList.Items) <= 0, nil
 }
 
-func installTraefik(ctx context.Context, p progress.Builder, client kclient.WithWatch, apply apply.Apply) (err error) {
+func installTraefik(ctx context.Context, p progress.Builder, apply apply.Apply) (err error) {
 	pb := p.New("Installing Traefik Ingress Controller")
 	defer func() {
 		_ = pb.Fail(err)

diff --git a/pkg/install/traefik.yaml b/pkg/install/traefik.yaml
@@ -180,6 +180,7 @@ spec:
           - "--metrics.prometheus.entrypoint=metrics"
           - "--providers.kubernetesingress"
           - "--providers.kubernetesingress.ingressendpoint.publishedservice=acorn-system/traefik"
+          - "--providers.kubernetesingress.allowexternalnameservices=true"
           - "--entrypoints.websecure.http.tls=true"
       volumes:
         - name: data