Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the Yandex 360 for Business DNS API #5214

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Support for the Yandex 360 for Business DNS API #5214

merged 10 commits into from
Sep 13, 2024

Conversation

WhiteAls
Copy link
Contributor

@WhiteAls WhiteAls commented Jul 20, 2024 •
edited
Loading

This pull request addresses issue #4555 by removing the outdated Yandex DNS API and adding support for the new Yandex 360 for Business DNS API.

The script has two modes: the standard mode, which works using a manually provided OAuth token and a mode with automatic OAuth token retrieval and renewal, which, however, requires user interaction during the first use.

More details at https://github.com/acmesh-official/acme.sh/wiki/dnsapi2#167-use-yandex-360-for-business-dns-api

Issue for the future bugs #5213

@github-actions GitHub Actions
Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@WhiteAls
Copy link
Contributor Author

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

I have reviewed the DNS API Dev Guide and DNS-API-Test and can confirm that my code complies with the guidelines provided.

I look forward to the review and am happy to make any further adjustments if needed.

@WhiteAls WhiteAls marked this pull request as draft July 26, 2024 15:24
@WhiteAls WhiteAls marked this pull request as ready for review August 1, 2024 17:28
This was referenced Aug 31, 2024
Closed
Closed
@WhiteAls
Little optimisations and fixes.
0fa20da 
- Removed or moved `_normalizeJson` processing to occur only when needed.
- Corrected usage of `_red` to `__red`.
- Simplified JSON parsing by using more concise `cut` commands.
- Simplify token refresh logic.
@WhiteAls
Copy link
Contributor Author

@Neilpang, I have made improvements to the integration as much as possible. Could you please review and accept my pull request if everything looks good?

@Neilpang Neilpang merged commit c71dcd7 into acmesh-official:dev Sep 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhiteAls @Neilpang