fix: rage4 - add error 400 and TXT cleanup #5197
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
So currently, the rage4 API is failing because we're sending the
Content-Type: application/json
, also the rm function is not retrieving theid
correctly from the response.This fixes both issues.
I understand that this PR won't be merged since it doesn't comply with https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test but I do not have the time or a Rage4 account that I can use for this (but I've tested this fix at my job and it does work). Maybe someone can run the CI/CD tests.