Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_1984.hosting - update _get_root check #5057

Merged
merged 1 commit into from
May 28, 2024

Conversation

phedoreanu
Copy link
Contributor

@phedoreanu phedoreanu commented Mar 19, 2024

This PR fixes the get_root check of the dns1984.hosting plugin.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@phedoreanu phedoreanu changed the title update _get_root check dns/dns.1984.hosting - update _get_root check Mar 19, 2024
@phedoreanu phedoreanu changed the title dns/dns.1984.hosting - update _get_root check dns_1984.hosting - update _get_root check Mar 19, 2024
@phedoreanu
Copy link
Contributor Author

@phedoreanu
Copy link
Contributor Author

Can you please review this PR? @Neilpang

Would be great to have it in the next release.

Thanks!

@Neilpang Neilpang merged commit a8f252e into acmesh-official:dev May 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants