Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rackspace Cloud DNS #2090

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Rackspace Cloud DNS #2090

merged 1 commit into from
Feb 13, 2019

Conversation

ianw
Copy link
Contributor

@ianw ianw commented Feb 13, 2019

Support Rackspace Cloud DNS

This commit is based on the original pull request by tcocca
#1297

Addtional cleanup was provided by senseisimple in
#1999

This pull request has squashed the changes for review, rebased, fixed a minor (but breaking) problem with the field ordering in the response, and added documentation per the API guide.


I have been through the DNS API dev guide and believe this is ready:

  1. cloudflare as reference : very similar
  2. script name : is consistent
  3. location : dnsapi/ for inclusion
  4. #!/usr/bin/env sh : yes
  5. has dns_myapi_<add|remove> functions: yes
  6. add function guides:
    6.1. gets fulldomain/txtvalue in dns_myapi_add(): yes
    6.2. save credentials in _add() : yes, via _rackspace_check_auth()
    6.3. detect root zone: yes, via _get_root_zone
    have tested
    example.org
    subdomain.example.org
    subsubdomain.subdomain.exmaple.org
    6.4. use _post/_get : yes, in _rackspace_rest
    6.4.a. wildcard txt certs: tested with *.example.org
    6.5 process strings using functions, no awk: yes
  7. rm function runs standalone: yes, records are removed

Support Rackspace Cloud DNS

This commit is based on the original pull request by tcocca
  acmesh-official#1297

Addtional cleanup was provided by senseisimple in
  acmesh-official#1999

This pull request has squashed the changes for review, fixed a minor
(but breaking) problem with the field ordering in the response, and
added documenation per the API guide.

Co-Author: Chris <[email protected]>
Co-Author: Ian Wienand <[email protected]>
@Neilpang
Copy link
Member

@ianw
Copy link
Contributor Author

ianw commented Feb 13, 2019

@Neilpang done with #2091

(sorry, didn't know if this was done after or before merge)

@Neilpang Neilpang merged commit b4fa97f into acmesh-official:dev Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants