Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5.0 #40

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Django 5.0 #40

merged 2 commits into from
Jun 20, 2024

Conversation

heykarimoff
Copy link
Contributor

@heykarimoff heykarimoff commented Apr 2, 2024

Upgrades Django from 4.2.11 to 5.0.

Went through Django 5.0 Release Notes and made necessary changes.

This involves upgrading following packages as well:

  • pytest-django
  • django-stubs

Resolves #21

@heykarimoff heykarimoff marked this pull request as draft April 2, 2024 22:16
@heykarimoff heykarimoff self-assigned this Apr 2, 2024
@heykarimoff
Copy link
Contributor Author

heykarimoff commented Apr 2, 2024

django-stubs is yet to support Django 5.0 officially. They are planning next release and it may take some time.

@a-musing-moose
Copy link
Contributor

@heykarimoff Looks like django-stubs has released a new version that now provides support for Django 5.0. https://pypi.org/project/django-stubs/

I think we should also change the default mypy configuration to enforce strict typing. If a new project really struggles with that level of typing they can always collectively make a decision to loosen things up. It it much harder to do in the other direction.

This should just be adding the following to pyproject.toml and removing the other individual check toggles.

[tool.mypy]
strict = true

@heykarimoff heykarimoff force-pushed the django5.0 branch 2 times, most recently from b791cb5 to a72a772 Compare June 20, 2024 10:26
@heykarimoff heykarimoff marked this pull request as ready for review June 20, 2024 10:34
Copy link
Contributor

@a-musing-moose a-musing-moose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks MK!

@a-musing-moose a-musing-moose merged commit eb5b401 into main Jun 20, 2024
3 checks passed
@a-musing-moose a-musing-moose deleted the django5.0 branch June 20, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Django 5.0
2 participants