-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Pin Config for layout 16 ALC1220 #758
Conversation
-Fixed sound not working after reboot from Windows with Realtek Driver installed - Huge Thanks to @mikebeaton
Hello i see you use verbs what 500 & 401 are supposed to do ? |
Hi |
thanx for explanation ! |
Actually the normal verb/argument packing is not because alc-verb has that quirk, compared to hda-verb, it's how you always pack the argument for 4 bit verbs (which iirc is all verbs that don't start with 7 or F). |
Can you show an example of that? I never actually experimented with those verbs. But I don't understand what the issue is exactly when sending those verbs, why they shouldn't work in alc-verb tool but as well in the pinconfigs. |
There isn't a problem, the verbs are laid out fine. I was just pointing out that the compressed verbs in the pinconfigs don't need to be in that format because anything about alc-verb. Just as an example If you want to do the first example with hda-verb, it's |
@vandroiy2013 @MacPeet Are you able to review this? The changes make sense to me, I worked with @narcyzzo to discover them. The added verbs are: 02050007 = set processing coefficient 0x07 on node 0x20 to 0x03c0 and set processing coefficient 0x1a on node 0x20 to 0x01c1. They fix sound not working after Realtek driver for this card in Windows. They were derived by reading the working values of all the processing coefficients when booting direct, and comparing them to the non-working values when warm booting from Windows with Realtek. If you manually apply them in Linux with |
Excuse me, how are you doing to dump coeffs ? |
In Linux you can dump them https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1850439/comments/153. For macOS I wrote a script to dump using |
Thanks you very much !!!!! I use another method to find these values. & I found sound works like a charm with these commands on my msi laptop. |
I hope the changes don't break the audio for users with the current layoutID16. Otherwise develop your own new ID! |
We believe it would actually fix for others, e.g. if you have Win with Realtek driver on your machine, this would probably fix the same issue of no sound after warm reboot into macOS from that. If you're interested and able to test that'd be really great. If not, it is your layout, so if you prefer could definitely be a different very similar layout on an alternative number. |
I don't have a Z390 myself. |
We used the same approach to generate final fixes for #759, and that is giving sound to other users who did not have it before. (On that card it was a case of no sound ever, except using Realtek driver in Windows.) So we think this approach is good. Very happy to rethink and separate the ids if any reports of any problems. So I guess go ahead? Thanks! |
Script and write-up now available. |
-Fixed sound not working after reboot from Windows with Realtek Driver installed