Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSD v0.1.0-beta - Table component updates #64

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

LSD v0.1.0-beta - Table component updates #64

wants to merge 9 commits into from

Conversation

jongomez
Copy link
Contributor

@jongomez jongomez commented Oct 3, 2023 •
edited
Loading

In this PR:

  • A new table footer component is introduced.
  • Some new styles were added to the table header.
  • The checkbox component and the TableRow component can now be controlled.
  • The storybook Table component was updated with new control logic for the checkboxes - if the header checkbox is clicked, all the items in the table are selected / deselected.
  • The storybook Table component now also handles radio inputs correctly.
  • Adds truncateContent prop and styles to the TableItem component. This is in figma as well - it's supposed to be the difference between "auto-layout" and "grid-aware" - one of them is truncated with ellipsis, the other one isn't.

Notion link

Figma link

Table footer component

Table with a footer

@jongomez jongomez requested a review from jeangovil October 3, 2023 12:24
@jeangovil jeangovil removed their request for review October 5, 2023 09:55
@jeangovil jeangovil marked this pull request as draft October 5, 2023 09:55
@jongomez jongomez mentioned this pull request Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jongomez