Requests iframe height for better sizing #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jongomez
force-pushed
the
request-iframe-height
branch
from
e995f9f to
b7b6c1a
Compare
jongomez
commented
Nov 7, 2023
jeangovil
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we request the storybook iframe's height, and use that height instead of hard coding 6000px for every single iframe.
I've also updated the storybookUrl to the permalink: https://main--63e4f71c39dc65c5c703c1e8.chromatic.com/ - @jeangovil happy to remove this if you don't think it makes sense.
How to test this
Go to this PR's chromatic link (current one at the time of me writing this is this) and go to a lsd component page. There shouldn't be large empty spaces at the bottom.