fix(cli): exclude **/node_modules/**/* from copyright header searching

achrinzafork · Apr 15, 2020 · 9d989bd · 9d989bd
1 parent d3ff0e2
commit 9d989bd
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/packages/cli/generators/copyright/index.js b/packages/cli/generators/copyright/index.js
@@ -133,6 +133,7 @@ module.exports = class CopyrightGenerator extends BaseGenerator {
     answers = answers || {};
     const exclude = this.options.exclude || '';
     const excludePatterns = exclude.split(',').filter(p => p !== '');
+    excludePatterns.push('**/node_modules/**/*');
 
     this.headerOptions = {
       copyrightOwner: answers.owner || this.options.owner,

diff --git a/packages/cli/test/fixtures/copyright/single-package/index.js b/packages/cli/test/fixtures/copyright/single-package/index.js
@@ -4,4 +4,12 @@
 // License text available at https://opensource.org/licenses/MIT
 
 // Use the same set of files (except index.js) in this folder
-exports.SANDBOX_FILES = require('../index')(__dirname);
+const files = require('../index')(__dirname);
+
+// add node_modules/third-party.js
+files.push({
+  path: 'node_modules',
+  file: 'third-party.js',
+  content: `module.exports = {}`,
+});
+exports.SANDBOX_FILES = files;
diff --git a/packages/cli/test/integration/generators/copyright.integration.js b/packages/cli/test/integration/generators/copyright.integration.js
@@ -70,6 +70,14 @@ describe('lb4 copyright', function () {
       `// This file is licensed under the ${spdxLicenseList['isc'].name}.`,
       `// License text available at ${spdxLicenseList['isc'].url}`,
     );
+
+    assertNoHeader(
+      ['node_modules/third-party.js'],
+      `// Copyright ACME Inc. ${year}. All Rights Reserved.`,
+      '// Node module: myapp',
+      `// This file is licensed under the ${spdxLicenseList['isc'].name}.`,
+      `// License text available at ${spdxLicenseList['isc'].url}`,
+    );
   });
 
   it('updates copyright/license headers with options.exclude', async () => {
@@ -97,7 +105,7 @@ describe('lb4 copyright', function () {
     );
 
     assertNoHeader(
-      ['lib/no-header.js'],
+      ['lib/no-header.js', 'node_modules/third-party.js'],
       `// Copyright ACME Inc. ${year}. All Rights Reserved.`,
       '// Node module: myapp',
       `// This file is licensed under the ${spdxLicenseList['isc'].name}.`,