Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

fix: Support passing name and context kwarg to create_task() #10

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

achimnol
Copy link
Owner

@achimnol achimnol commented Apr 16, 2023

Python 3.11's asyncio.create_task() introduces the new optional keyword-only argument context.

@achimnol achimnol added the bug Something isn't working label Apr 16, 2023
@achimnol achimnol self-assigned this Apr 16, 2023
@achimnol achimnol changed the title fix: Support passing context kwarg to create_task() fix: Support passing name and context kwarg to create_task() Apr 16, 2023
@achimnol achimnol merged commit 88bc66f into master Apr 16, 2023
@achimnol achimnol deleted the fix/passing-context-kwargs-to-create_task branch April 16, 2023 08:40
achimnol added a commit that referenced this pull request Apr 19, 2023
achimnol added a commit that referenced this pull request Apr 19, 2023
achimnol added a commit to aio-libs/aiomonitor that referenced this pull request Apr 24, 2023
* Add optional task creation stack chains to 'where' command (achimnol#1)
* feat: Rewrite ps command to provide more concise view (achimnol#2)
* feature: print numbers of total tasks when executing `ps` (achimnol#3)
* Adopt `prompt_toolkit` and support concurrent clients (achimnol#4)
* feat: Migrate to Click-based command line interface (achimnol#5)
* fix: Reimplement console command (achimnol#6)
* Support auto-completion of commands and arguments (achimnol#7)
* Implement cancellation chain tracker (achimnol#8)
* New commands:
  - `ps-terminated` (`pt`, `pst`)
  - `where-termianted` (`wt`)
* New options:
  - `ps`, `pt`: `-f`, `--filter` to search task logs by their names and
    coroutine summary strings
  - `aiomonitor.Monitor` now has the history limit option (default: 1000)
* Selective persistent termination logs (achimnol#9)
- We should preserve the termination log of tasks that are supposed to
  be long-running and not terminated during the entire application
  lifecycle (e.g., server apps), when there are many volatile tasks
  continuously spawned and destroyed, regardless of the history limit.
* fix: Support passing `name` and `context` kwarg to `create_task()` (achimnol#10)
* fix: Regression in Python 3.10 due to achimnol#10 (achimnol#11)

---------

Co-authored-by: Kyujin Cho <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant