Add Project Affiliations Menu to Main Interface #9417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
reviewed
Oct 25, 2024
php/libraries/User.class.inc
Outdated
| Store examiner's centerID with active status and radiologist flag, | ||
| ensuring centerID is a string | ||
| */ | ||
| $examiner_info[(string)$val['centerID']] = [ |
There was a problem hiding this comment.
Do we need that change? Does it solve an error?
There was a problem hiding this comment.
it was to stay consistent with my changes when I used to cast the projects and sites into strings but it doesn't affect functionality so it can removed.
laemtl
reviewed
Oct 25, 2024
| if (!empty($examiner_check) && !is_null($examiner_check)) { | ||
| $examiner_info = []; | ||
|
|
||
| if (!empty($examiner_check)&& !is_null($examiner_check)) { |
There was a problem hiding this comment.
Add back the space before &&
|
Notes from Oct. 25 EEG meeting discussion :
|
laemtl
reviewed
Oct 25, 2024
| ); | ||
| } else { | ||
| return $this->userInfo[$var]; | ||
| return $this->userInfo[$var] ?? null; |
There was a problem hiding this comment.
Can you explain the reasoning behind this change?
There was a problem hiding this comment.
it's to prevent an error if the key doesn't exist in the userinfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a Project Affiliations menu to the application's main interface, mirroring the existing Site Affiliations menu.
Changes Implemented
User Class Enhancements
Userclass to retrieve associated projects using the user's ID using user_projects_query.Template Modifications
Middleware Adjustments
Userclass.using getProjectIDs() and >getProjectNames()).GUI
Affiliations Menus with single project or site
Affiliations Menus with multiple projects or sites
Suggested Changes
Affiliations drop-down menu with fixed hieight and scrollable option
Removed separate Project and Sites Menus
Related Issue