-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Project Affiliations Menu to Main Interface #9417
base: main
Are you sure you want to change the base?
Conversation
php/libraries/User.class.inc
Outdated
Store examiner's centerID with active status and radiologist flag, | ||
ensuring centerID is a string | ||
*/ | ||
$examiner_info[(string)$val['centerID']] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need that change? Does it solve an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was to stay consistent with my changes when I used to cast the projects and sites into strings but it doesn't affect functionality so it can removed.
if (!empty($examiner_check) && !is_null($examiner_check)) { | ||
$examiner_info = []; | ||
|
||
if (!empty($examiner_check)&& !is_null($examiner_check)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back the space before &&
Notes from Oct. 25 EEG meeting discussion :
|
); | ||
} else { | ||
return $this->userInfo[$var]; | ||
return $this->userInfo[$var] ?? null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the reasoning behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's to prevent an error if the key doesn't exist in the userinfo.
Description
This PR introduces a Project Affiliations menu to the application's main interface, mirroring the existing Site Affiliations menu.
Changes Implemented
User Class Enhancements
User
class to retrieve associated projects using the user's ID using user_projects_query.Template Modifications
Middleware Adjustments
User
class.using getProjectIDs() and >getProjectNames()).GUI
Affiliations Menus with single project or site
Affiliations Menus with multiple projects or sites
Suggested Changes
Affiliations drop-down menu with fixed hieight and scrollable option
Removed separate Project and Sites Menus
Related Issue