Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParameterTransformer. #143

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix ParameterTransformer. #143

merged 1 commit into from
Sep 13, 2023

Conversation

pipme
Copy link
Collaborator

@pipme pipme commented Sep 12, 2023

  • Avoid int type issue by casting input to float.
  • Convert functions for bound transformation to explicit functions instead of closures to avoid potential silent deepcopy issues.

@pipme
Fix ParameterTransformer.
6fcf87d 
- Avoid int type issue by casting input to float.
- Convert functions for bound transformation to explicit functions instead of closures for avoiding silent deepcopy issues.
@lacerbi lacerbi self-requested a review September 13, 2023 07:21
@lacerbi lacerbi merged commit 4216720 into main Sep 13, 2023
10 checks passed
@pipme pipme deleted the fix-parameter-transformer branch May 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lacerbi lacerbi lacerbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipme @lacerbi