Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change autogenerated adminPassword from 3 to 2 words #25

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

sdsznsk
Copy link
Contributor

@sdsznsk sdsznsk commented Nov 22, 2023

When merged, this PR will:

  • title

Sometimes the words used to generate password are too long and the password will exceed the limit:

# 2023-11-22T00:06:12.302710500Z    BACKEND   (E): Param "#/game/passwordAdmin" has surpassed the maximum limit of value/length. The maximum allowed is 32.`

I think reducing the # of words is better than cutting after 32 character.

Or we could just regenerate if the pass exceeds 32 chars 🤔

@jonpas jonpas added the bug Something isn't working label Nov 22, 2023
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is completely fine, it can always be set manually anyways.

@BrettMayson BrettMayson merged commit 002e6be into acemod:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants