This repository has been archived by the owner on May 24, 2022. It is now read-only.
Headless - Fix end mission not respecting virtual curators #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
changed the title
PabstMirror
reviewed
Nov 19, 2018
| GVAR(endMissionCheckDelayed) = false; | ||
| TRACE_1("Players are present",count (call CBA_fnc_players)); | ||
| // Exit if no players of virtual curators present | ||
| if (call CBA_fnc_players isEqualTo [] && {allCurators isEqualTo []}) exitWith { |
There was a problem hiding this comment.
allCurators is the logics, which will continue to exist
Checking if this connected unit is a player seems to work
(allCurators select {isPlayer getAssignedCuratorUnit _x}) isEqualTo []
There was a problem hiding this comment.
Without this, the test would always fail if there were zeus modules down.
Tested on dedicated with a virtual zeus and it seems to work correctly
getAssignedCuratorUnit returns the virtual zeus
and isPlayer returns true when player is connected and false on disconnect
There was a problem hiding this comment.
Thanks for the test and fix!
PabstMirror
approved these changes
Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
;)