Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Change FUNC to LINKFUNC where appropriate #9882

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the ignore-changelog Release Notes: Excluded label Mar 27, 2024
@jonpas jonpas added this to the 3.17.1 milestone Mar 27, 2024
@jonpas
Copy link
Member

jonpas commented Mar 28, 2024

I think this is good to merge for 3.17.0 as well.

I am not sure replacing DFUNC is correct though? @PabstMirror

@jonpas jonpas modified the milestones: 3.17.1, 3.17.0 Mar 28, 2024
@PabstMirror
Copy link
Contributor

Should be fine
iirc it may have been done to reduce stack-trace on frequent calls
but I don't think that gets used much and can always be changed if needed when debugging

one thing to watch out for is {call FUNC(x)} handling exitWith differently on some vanilla EHs
but I didn't see anything that would cause problems

@PabstMirror PabstMirror merged commit 415d2f6 into master Mar 28, 2024
5 checks passed
@PabstMirror PabstMirror deleted the linkfunc branch March 28, 2024 18:57
@johnb432
Copy link
Contributor Author

johnb432 commented Mar 28, 2024

one thing to watch out for is {call FUNC(x)} handling exitWith differently on some vanilla EHs but I didn't see anything that would cause problems

Yea, I specifically omitted any vanilla EH for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants