Dragging - Corpse carrying and dragging - continued #9269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dystopian <[email protected]>
Co-authored-by: Dystopian <[email protected]>
johnb432
commented
Jul 19, 2023
| _target setPosATL [0, 0, -10]; | ||
|
|
||
| // Turn off PhysX | ||
| [QEGVAR(common,awake), [_target, false]] call CBA_fnc_globalEvent; |
There was a problem hiding this comment.
In my testing toggling awake seemed to be fine, however adding a delay to the execution (either as absolute or x amount of frames) might be a good idea.
Any suggestions/comments?
commy2
reviewed
Jul 20, 2023
| @@ -11,35 +11,36 @@ | |||
| * Can the unit carry the object? <BOOL> | |||
| * | |||
| * Example: | |||
| * [player, cursorTarget] call ace_dragging_fnc_canCarry | |||
| * [player, cursorObject] call ace_dragging_fnc_canCarry | |||
There was a problem hiding this comment.
Why cursorObject anywhere? That's way too fiddly compared to cursorTarget and returns irrelevant stuff like map props.
|
This should have been two PRs. I don't mind the general code cleanup at all, but it makes hard to see what actually changed. |
|
Splitting into 3 different PRs. |
This was referenced Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I had found out a way to implemented corpse carrying, but it was somewhat clunky. However, when trying to implement said solution, I found a better one and wanted to share it.
Pinging those were most heavily involved with the above mentioned PR:
@BaerMitUmlaut @PabstMirror @Dystopian
I haven't tested this PR a lot, but the initial testing was promising imo.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.