Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - Add dependencies page #8706

Merged
merged 10 commits into from
Dec 2, 2021
Merged

Documentation - Add dependencies page #8706

merged 10 commits into from
Dec 2, 2021

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Nov 26, 2021

When merged this pull request will:

@bux
Copy link
Member

bux commented Nov 26, 2021

I don't like that this is not automated.
You should either write your own (e.g. python) script to gather the information or make use / copy functionality from: https://github.com/acemod/ACE3/blob/master/docs/_includes/dependencies_list.md

@jonpas
Copy link
Member

jonpas commented Nov 26, 2021

Agreed with @bux. The existing script output might be able to be reused for this even.

@jonpas
Copy link
Member

jonpas commented Nov 26, 2021

image

@jonpas jonpas added this to the Ongoing milestone Nov 26, 2021
@jonpas
Copy link
Member

jonpas commented Nov 26, 2021

All automated and cleaned up now.

Also fixed some Liquid warnings, finally.

@jonpas jonpas requested a review from bux November 28, 2021 01:19
@jonpas jonpas requested a review from bux December 2, 2021 14:04
Copy link
Member

@bux bux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@jonpas jonpas merged commit 59fe345 into acemod:master Dec 2, 2021
@rautamiekka
Copy link
Contributor

What does the removal of deps from the page solve ? That way one has to find the deps page and look through it. Even a link to the deps page woulda been better than nothing at all; nothing at all also makes it seem there's no modularity and/or deps.

@jonpas
Copy link
Member

jonpas commented Dec 2, 2021

AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
@PabstMirror PabstMirror added the ignore-changelog Release Notes: Excluded label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to find which Addon/-s require a certain one ?
5 participants