Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - Rework arsenal docs #8650

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Documentation - Rework arsenal docs #8650

merged 2 commits into from
Nov 11, 2021

Conversation

BaerMitUmlaut
Copy link
Member

@BaerMitUmlaut BaerMitUmlaut commented Oct 29, 2021

When merged this pull request will:

  • Fix the title being "ACE Arsenal" instead of just "Arsenal" (see here)
  • Use tables for parameter documentation instead of copied doccomments
  • Move "Access to ACE Arsenal" in front of "Virtual Items", since the latter requires the former
  • Improve general consistency
Screenshot

@BaerMitUmlaut BaerMitUmlaut changed the title Rework arsenal docs Documentation - Rework arsenal docs Oct 29, 2021
@jonpas
Copy link
Member

jonpas commented Oct 29, 2021

Fix the title being "ACE Arsenal" instead of just "Arsenal" (see here)

This wasn't a "bug", it was on purpose to not confuse it with Vanilla Arsenal. And I still agree with that.

@BaerMitUmlaut
Copy link
Member Author

Undid the rename.

@PabstMirror PabstMirror added this to the Ongoing milestone Oct 31, 2021
@PabstMirror PabstMirror added the ignore-changelog Release Notes: Excluded label Oct 31, 2021
@rautamiekka
Copy link
Contributor

While on it, could you add an explanation what the mentioned 'virtual items' are ? If I didn't fail the Biwiki search, even it doesn't explain them. The best I can deduce: they're a non-existent form of anything normally physical you could, for ex, store in your inventory, and they don't take up space. Magically appearing items, if you will.

@jonpas jonpas merged commit 3c59523 into master Nov 11, 2021
@jonpas jonpas deleted the arsenal-docs branch November 11, 2021 12:12
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants