Update contribution documents #8382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reflect true attribution practices - Reflect true merge process (this changed a long time ago)
We have almost never used these and serve as a source of confusion for new contributors.
kymckay
added
kind/documentation
ignore-changelog
Caught in a bad regex
jonpas
reviewed
Aug 16, 2021
Comment on lines
+174
to
+176
| Every function includes the `script_component.hpp` file on the first line. Any additional includes or defines must be below this include. | ||
|
|
||
| All code written must be below this include and any potential additional includes or defines. |
There was a problem hiding this comment.
additional includes or defines
Duplicated.
There was a problem hiding this comment.
I thought the same, but think it's just badly worded. Code must appear below all includes and defines.
Includes and defines must appear below the script component include.
There was a problem hiding this comment.
This whole document could probably use a once over separately. I just spotted the outdated info while doing this. 👍
Co-authored-by: jonpas <[email protected]>
jonpas
approved these changes
Aug 16, 2021
kymckay
commented
Aug 16, 2021
PabstMirror
approved these changes
Aug 16, 2021
Drofseh
reviewed
Aug 17, 2021
| The people responsible for merging changes to existing addons are the maintainers listed in the README.md file of the respective addon folder. | ||
| #### Merge Criteria | ||
|
|
||
| All pull requests must receive approval from a maintainer and must pass all required continuous integration checks before they can be merged. |
There was a problem hiding this comment.
Should this be members instead of maintainers now?
|
|
||
| #### New Addons / Other Changes | ||
| If a pull request adds a new addon, or changes something else, like the README, everyone has 72 hours to comment on the changes. After that, one of the project leads will merge it. | ||
| Non-trivial pull requests should ideally be thouroughly reviewed by multiple maintainers or at least one maintainer highly familiar with any code modified. |
LinkIsGrim
pushed a commit
to LinkIsGrim/ACE3
that referenced
this pull request
Aug 28, 2021
* Update code guidelines for script_component * Update contributing documents for pull requests - Reflect true attribution practices - Reflect true merge process (this changed a long time ago) * Remove listed maintainer from component readmes We have almost never used these and serve as a source of confusion for new contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: