-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical Treatment - Allow diagnosing death/CA (invalidates old setting) #8162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this break use of true/false
in the setting (eg. via settings file)?
Co-authored-by: mharis001 <[email protected]>
So I thought that if we converted bool to list, it would do false=0, true=1, but that doesn't seem to be true in cba_settings So right now it will ignore any saved true/false settings and use the default? |
@@ -3699,6 +3702,12 @@ | |||
<Chinese>%1 沒有反應</Chinese> | |||
<Turkish>%1 tepki vermiyor</Turkish> | |||
</Key> | |||
<Key ID="STR_ACE_Medical_Treatment_Check_Response_CardiacArrest"> | |||
<English>%1 is not responsive, taking shallow gasps and convulsing</English> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gasping is fairly common in early cardiac arrest, not sure if convulsing is. I am basing this on civilian first aid training (that I luckily have not had to use yet), not military experience.
(This was not meant as a review...)
Anything to consider/check/test/review on this? |
Is it ok to break the existing setting by changing it's type, or should I just add a 2nd bool? |
There, noted in changelog now, I think that's fine. Not changing it won't cause a script error, right? |
cba settings should check types and maybe complain in rpt, but should all be handled safely |
Should be fine. We have made a similar change before to the advanced bandages and bandage reopening settings. |
Adds a 3rd setting level to advancedDiagnose that shows death/CA state
Doing CPR for 5 minutes on your buddy, not sure if he's alive or dead, might be heartbreakingly realistic
but I feel like some players will want a way to diagnose their state easily without having to drop down to basic diagnose