Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical - Add Global Wound Reopen Chance Modifer #7747

Merged
merged 8 commits into from
Jun 13, 2020
Merged

Medical - Add Global Wound Reopen Chance Modifer #7747

merged 8 commits into from
Jun 13, 2020

Conversation

dgibso29
Copy link
Contributor

@dgibso29 dgibso29 commented Jun 3, 2020 •
edited
Loading

As it says on the tin, this PR adds a Global Wound Reopen Chance Modifier to the Medical Treatment Addon Settings. This modifier is utilized in fnc_handleBandageOpening.sqf, where it modifies the re-open chance. This is applied per bandage/wound, allowing the various bandage's distinctive values to be modified equally.

This has been tested and is working.

I'll pop in to Slack, but please let me know what else needs to be done, etc. Thank you!

image

@mharis001 mharis001 changed the title [Medical] Add Global Wound Reopen Chance Modifer Medical - Add Global Wound Reopen Chance Modifer Jun 3, 2020
@dgibso29
Copy link
Contributor Author

dgibso29 commented Jun 3, 2020 •
edited
Loading

The display name should probably have "Modifier" added at the end to make its function more clear.

@mharis001 mharis001 added the kind/feature Release Notes: **ADDED:** label Jun 3, 2020
@mharis001 mharis001 added this to the 3.13.3 milestone Jun 3, 2020
mharis001
mharis001 reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a name like "Wound Reopening Coefficient" might be better. Description could be: "Coefficient for controlling the wound reopening chance. The final reopening chance is determined by multiplying this value with the specific reopening chance for the wound type and bandage used."

addons/medical_treatment/functions/fnc_handleBandageOpening.sqf Outdated Show resolved Hide resolved
@dgibso29
PR Feedback #1
4b430fc 
- Removed unnecessary whitespace on LN 46
- Call global var directly at LN 87
- Updated Wound Reopen Chance localized name & description
@dgibso29
Copy link
Contributor Author

dgibso29 commented Jun 3, 2020

I think a name like "Wound Reopening Coefficient" might be better. Description could be: "Coefficient for controlling the wound reopening chance. The final reopening chance is determined by multiplying this value with the specific reopening chance for the wound type and bandage used."

Agreed & changed. Thanks!

@dgibso29 dgibso29 requested a review from mharis001 June 3, 2020 14:02
dgibso29 added 2 commits June 3, 2020 10:21
@dgibso29
PR Feedback #2
5473c72 
- Increased reopen coefficient upper limit from 2 to 5.
@dgibso29
Changed author credit to reflect GitHub email.
200d38f
@dgibso29
Copy link
Contributor Author

dgibso29 commented Jun 3, 2020

@mharis001 How do I add my name to the PBO author array? Thank you!

@PabstMirror PabstMirror merged commit 185c15d into acemod:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zharf zharf zharf left review comments

@mharis001 mharis001 mharis001 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.13.3
Development

Successfully merging this pull request may close these issues.
4 participants
@dgibso29 @zharf @PabstMirror @mharis001