Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NightVision - Don't apply AimDownSightsBlur on optics with integrated night vision #7548

Merged
merged 3 commits into from
Feb 23, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 23, 2020

When merged this pull request will:

To explain: If the Magnification is > 3, we can safely assume that we're not looking down iron/holo/cqb sights, but are instead dealing with an optic with actual (!= from RMB zoom) magnification and thus integrated night vision (potentially with its own blur effects).

We need to refresh the effect every time magnification is changed from <3 to >3 and vice versa, as there is no OpticsMode event.

@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label Feb 23, 2020
@commy2 commy2 added this to the 3.13.1 milestone Feb 23, 2020
@commy2 commy2 self-assigned this Feb 23, 2020
@jonpas jonpas changed the title don't apply AimDownSightsBlur on optics with integrated night vision NightVision - Don't apply AimDownSightsBlur on optics with integrated night vision Feb 23, 2020
@commy2
Copy link
Contributor Author

commy2 commented Feb 23, 2020

This was tested with BWA3_optic_ZO4x30_RSAS_NSV (optic with hmd nvg compatible CQB holo optics mode, and internal nvg scope optics mode) and it works as expected: blur only applied on CQB.

@commy2 commy2 merged commit ae7feae into master Feb 23, 2020
@commy2 commy2 deleted the fix-AimDownSightsBlur branch February 23, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVS scope has blur
2 participants