Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload - Fix static weapon ammo check #7541

Merged

Conversation

TheCandianVendingMachine
Copy link
Contributor

For some reason ARMA never returns any muzzle for crewed/non crewed static weapons. Work around this by always returning whatever weapon the static weapon has no matter what

fixes #7540

For some reason ARMA never returns any muzzle for crewed/non crewed static weapons. Work around this by always returning whatever weapon the static weapon has no matter what
@PabstMirror PabstMirror added this to the 3.13.1 milestone Feb 22, 2020
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Feb 22, 2020
@commy2
Copy link
Contributor

commy2 commented Feb 22, 2020

For some reason ARMA never returns any muzzle for crewed/non crewed static weapons.

Probably the weapon config missing:

muzzles[] = {"this"};

or having

muzzles[] = {};

or something.

@PabstMirror PabstMirror changed the title fix static weapon ammo check Reload - fix static weapon ammo check Feb 22, 2020
@jonpas jonpas changed the title Reload - fix static weapon ammo check Reload - Fix static weapon ammo check Feb 22, 2020
@PabstMirror PabstMirror merged commit 5172e77 into acemod:master Feb 22, 2020
@TheCandianVendingMachine
Copy link
Contributor Author

For some reason ARMA never returns any muzzle for crewed/non crewed static weapons.

Probably the weapon config missing:

muzzles[] = {"this"};

or having

muzzles[] = {};

or something.

Yeah but this is the case for every single static weapon, vanilla and modded. If you go currentMuzzle gunner vehicle player it will return the correct muzzle if a person is on the weapon, but that isnt a good check if no ones in the weapon.

I'm personally going with: it worked before and an ARMA update changed behaviour. According to the biki By default the inherited muzzle for a weapon is: muzzles[] = {"this"}; as well, so it seems like it was correct behaviour and now it isn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For some non-vanilla statics, "Check ammo" doesn't work right
4 participants