Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Fix being stuck in unconscious animation after ragdoll #7499

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

diwako
Copy link
Contributor

@diwako diwako commented Jan 30, 2020

When merged this pull request will:

  • Get units out of unconscious animation after a physix object hit them

Addressing issue #7403

Note:
This code might not be fully optimal as it runs on every local unit. Thanks to commy2 for show me the way of propositional calculus.

https://streamable.com/com1h

Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see suggestion

@PabstMirror PabstMirror added this to the 3.13.1 milestone Feb 7, 2020
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Feb 7, 2020
@PabstMirror
Copy link
Contributor

I think this will fix the problem, but for performance reasons I don't really like the anim EH being run on all units, but until we find anything better this is good for now

@jonpas jonpas changed the title Medical - Fix being stuck in unconscious animation after none unconscious ragdoll Medical - Fix being stuck in unconscious animation after PhysX ragdoll Feb 22, 2020
@jonpas jonpas changed the title Medical - Fix being stuck in unconscious animation after PhysX ragdoll Medical - Fix being stuck in unconscious animation after ragdoll Feb 22, 2020
@jonpas jonpas merged commit bd040ca into acemod:master Feb 22, 2020
@diwako diwako deleted the fix_being_stuck_after_ragdoll branch February 23, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
Development

Successfully merging this pull request may close these issues.

4 participants