Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common - Optimize arithmeticGetResult function #7232

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Common - Optimize arithmeticGetResult function #7232

merged 2 commits into from
Oct 8, 2019

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Optimize arithmeticGetResult common function by using selectMax and selectMin commands rather than count loop
    • Will provide a small performance improvement
    • For the current ACE_setCustomAimCoef (2 sources) with the "max" operation: ~0.0234 ms to ~0.0207 ms
  • Change count to forEach (faster than count + true/false/nil)
  • Cleanup some unnecessary parentheses

@mharis001 mharis001 added the kind/optimization Release Notes: **IMPROVED:** label Oct 7, 2019
@mharis001 mharis001 added this to the 3.13.0 milestone Oct 7, 2019
@PabstMirror PabstMirror merged commit 13ffc07 into master Oct 8, 2019
@PabstMirror PabstMirror deleted the optimize-arithmetic-sets branch October 8, 2019 00:41
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp1 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mharis001 @PabstMirror