Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realistic names - Contact DLC rifles added #7155

Merged
merged 7 commits into from
Oct 6, 2019
Merged

Realistic names - Contact DLC rifles added #7155

merged 7 commits into from
Oct 6, 2019

Conversation

Laid3acK
Copy link
Contributor

When merged this pull request will:

  • Add the translation of the Contact rifles (except shotguns).

References from the MSBS Grot Wiki and the manufacturer for the Promet.
References from various sources and Wikis for the AK15 variants (AK12 chambered in 7.62x39 mm).

@Drofseh
Copy link
Contributor

Drofseh commented Aug 30, 2019

English first for string tables?

<Russian>AKM</Russian>
<German>AKM</German>
<Czech>AKM</Czech>
<English>AKM</English>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move English to first position in stringtable. We forgo the second English entry Original, because it is a duplicate, however, this means the first language is the fall back if the game language is missing.
Therefore English should be at first position.

Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English first in stringtable

@Blutze
Copy link
Contributor

Blutze commented Aug 31, 2019

Might wanna include info about the cartridge in the names for the MSBSs, as this is not the standard 5.56 variant. The older naming system described on the wiki seem to allow that already, otherwise just drop a (6.5x39) on them.

MSBS-6.5B GL
Grot B20PSBI-M2 (6.5x39)

Something along those lines.

@Laid3acK
Copy link
Contributor Author

Laid3acK commented Sep 5, 2019

Maybe should be like that but, for example,
the Promet Marksman 3D model is a bullpup version with a 22" barrel which doesn't exist.
The real one is chambered in 7.62x51 and looks like that : MSBS DMR rifle

So, an exact designation with a wrong caliber has no sens imo, as many rifles in this game.
The reason i chosen a compromise with the BI and the manufacturer names.

  • All English entries first fixed.
  • Contact pistol and launcher added.
  • Minors updates.

@PabstMirror PabstMirror merged commit ce0ccb2 into acemod:master Oct 6, 2019
@Laid3acK Laid3acK deleted the contact_translation branch October 6, 2019 16:21
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants