Gunbag - Move gunbag type from inheritance to config property #7022
Conversation
|
Documentation would be nice. |
|
new gunbag framework page? I never wrote any wiki stuff before. |
|
Yes, new page. |
|
Need help with the texting. |
| ```cpp | ||
| class Bag_Base; | ||
| class ace_gunbag: Bag_Base { | ||
| _generalMacro = QUOTE(ADDON); |
There was a problem hiding this comment.
Mh? I don't see it. It's 4 space for me.
hm hearing framework uses 4+5 space indent for two levels...
HuntIR uses 4+4+4+2 for 4 levels.. wtf?
overheating uses normal 4 space indent.
grenades also uses 4 space.
I use 4 space too. What's the correct way to do it?
There was a problem hiding this comment.
I've removed _generalMacro from the doc as we don't need it anyway.
There was a problem hiding this comment.
Idk, not all lines were indented the same when I looked at diff.
|
It is a framework. Feature page would describe it for users, framework page describes the framework. |
|
A additional feature page about gunbag would also not be a bad idea, currently we have nothing.
https://github.com/acemod/ACE3/pull/7022/files#diff-b96463f2310bb0b2b9637bf3594f2653R17 |
|
"Thing" is a bite crude I guess, but "gunbag backpack" sounds silly too. |
|
|
Co-Authored-By: mharis001 <[email protected]>
|
Sounds good to me now. |
PabstMirror
changed the title
* Move gunbag type from inheritance to config property * Add gunbag framework wiki * Remove _generalMacro from doc * Apply documentation suggestions Co-Authored-By: mharis001 <[email protected]>
From Feature request
#3594 (comment)
@ImplicitDeny
Makes it easier for 3rd parties to create gunbags without adding a ACE dependency.
Slight performance hit (I assume) for config lookup instead of isKindOf, though isKindOf is also not much cheaper I think. Not big enough difference to be worth testing or caching.
Or... Maybe caching, leaving that up to you, don't think its worth.
Noticed we don't have a gunbag wiki page. Someone should add one someday ^^