Run vitals loop during cardiac arrest #7013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can see we don't actually need to run the vitals loop during cardiac arrest. It also looks like the bleedout condition will never occur currently (bleeding stops during cardiac arrest unless CPR is administered). I'll fix this in a separate PR.
|
I think I want to fix this by having the loop running and then making bleeding continue to occur but at quarter speed or something if heart rate is 0. Need to investigate how CPR can continue to work if the loop is still running (either having it act as a heart rate modifier or just skip heart rate updates if in cardiac arrest). Also need to prevent the status change events from firing a bunch (e.g. low blood puts you into cardiac arrest and because the loop keeps running the event keeps firing). Edit: The events firing repeatedly might not be an issue, currently the same thing already happens for other states |
kymckay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bleedout condition will never occur currently since bleeding stops during cardiac arrest unless CPR is administered and the vitals loop doesn't even run so the condition is never checked.
This fixes that by running the loop during cardiac arrest and also allows bleeding to continue if heart rate is 0, just at a fixed reduced rate.
Additionally this fixes #6530