Cookoff - Fix shell detonation #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bcb4214.
|
Great this must be it ! |
PabstMirror
changed the title
dedmen
reviewed
May 7, 2019
| @@ -87,7 +87,7 @@ if (_amountOfMagazines > 0) exitWith { | |||
| playSound3D [_sound, objNull, false, (getPosASL _vehicle), 2, 1, 1300]; | |||
|
|
|||
| if (random 1 < 0.15) then { | |||
| [_vehicle, _ammo, _speed, random 1 < 0.15] call _spawnProjectile; | |||
| [_vehicle, _ammo, _speed, true] call _spawnProjectile; | |||
There was a problem hiding this comment.
Don't need the _flyAway parameter in _spawnProjectile if we always set it to true.
There was a problem hiding this comment.
For shotgrenade and a few others it is still randomized. See L97ff
|
Only thing missing here is I would have added a comment above this line explaining as much for future reference |
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* abc * Revert "abc" This reverts commit bcb4214. * Update to current commit * ShotShell requires velocity to simulate itself, so always spawn it with velocity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ShotShell requires velocity to properly simulate itself, so when detonating ammo always give it velocity. The RHS vehicle example in the issue is just a ShotShell that looks like a missile
Example:
https://youtu.be/GinftkYl5Mo