Add keep engine of vehicles running after getting out #6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
requested changes
Mar 22, 2019
Co-Authored-By: brainslush <[email protected]>
Co-Authored-By: brainslush <[email protected]>
Co-Authored-By: brainslush <[email protected]>
commy2
reviewed
Mar 22, 2019
commy2
reviewed
Mar 22, 2019
commy2
reviewed
Mar 22, 2019
|
Do we even need setVariable public for this? I would do the following things:
This should handle the correct state for JIP, because it is either the state when you connect as client, or whicher was last toggled by Engine event. InitPost and Engine are event with global args, so no strain on the network is needed. |
Dystopian
reviewed
Mar 22, 2019
commy2
reviewed
Mar 23, 2019
commy2
reviewed
Mar 23, 2019
commy2
reviewed
Mar 24, 2019
Co-Authored-By: brainslush <[email protected]>
commy2
reviewed
Mar 31, 2019
commy2
reviewed
Mar 31, 2019
commy2
reviewed
Mar 31, 2019
commy2
reviewed
Mar 31, 2019
commy2
reviewed
Mar 31, 2019
commy2
reviewed
Mar 31, 2019
commy2
reviewed
Mar 31, 2019
Co-Authored-By: brainslush <[email protected]>
Co-Authored-By: brainslush <[email protected]>
Co-Authored-By: brainslush <[email protected]>
commy2
reviewed
Mar 31, 2019
Co-Authored-By: brainslush <[email protected]>
commy2
approved these changes
Mar 31, 2019
jonpas
approved these changes
Mar 31, 2019
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
Adds a feature which leaves the vehicle engine running after getting out. So, it requires the driver to switch off the engine of the vehicle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I tested it locally and have tested it numerous times as part of another mod before moving it to ACE3. Please retest as I could made have mistakes while adapting the code for ACE3.