Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickmount - optimize generating subActions #6883

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Quickmount - optimize generating subActions #6883

merged 1 commit into from
Mar 22, 2019

Conversation

PabstMirror
Copy link
Contributor

Caches call to FUNC(addFreeSeatsActions) on the actions args
Before it would double call the function each time (~0.8ms on a Chinook)

@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Mar 21, 2019
@PabstMirror PabstMirror added this to the 3.12.7 milestone Mar 21, 2019
mharis001
mharis001 approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in-game, looks good.

@PabstMirror PabstMirror merged commit 2ea029c into master Mar 22, 2019
@PabstMirror PabstMirror deleted the quickMountCacheActions branch March 22, 2019 02:29
@PabstMirror PabstMirror modified the milestones: 3.12.7, 3.13.0 Jul 5, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@PabstMirror
Quickmount - optimize subActions (#6883)
7f2756b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PabstMirror @mharis001