Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grenades - Add CTS 7290 9-bang flashbang #6856

Merged
merged 18 commits into from
Dec 17, 2019
Merged

Grenades - Add CTS 7290 9-bang flashbang #6856

merged 18 commits into from
Dec 17, 2019

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Mar 9, 2019

Requires #6848

@dedmen dedmen force-pushed the cts-7290 branch 2 times, most recently from 65a4e60 to 7ac5873 Compare March 9, 2019 18:36
@dedmen
Copy link
Contributor Author

dedmen commented Mar 9, 2019

arma3_x64_2019-03-09_19-42-46

@dedmen dedmen changed the title Add CTS 7290 9-bang flashbang grenade WIP: Add CTS 7290 9-bang flashbang grenade Mar 9, 2019
@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Mar 9, 2019
@jonpas jonpas added this to the 3.13.0 milestone Mar 9, 2019
bovine3dom
bovine3dom suggested changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@bovine3dom bovine3dom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config, which you solicited, and some comments, which you didn't :)

addons/grenades/CfgAmmo.hpp Show resolved Hide resolved
addons/grenades/CfgAmmo.hpp Show resolved Hide resolved
addons/grenades/config.cpp Show resolved Hide resolved
addons/grenades/stringtable.xml Show resolved Hide resolved
@bux
Copy link
Member

bux commented Mar 10, 2019 •
edited
Loading

@dedmen Could you make it so, that the label is slightly rotated to the left or to the right.
Imho it's too perfectly centered right now. It feels to me like either a reporter making sure that his channel's logo is visible on his mic or someone holding a coke with the label visible to the camera straight out of a coke ad

And the label is too comical for my taste. Can't we just copy the original label?
It currently looks more like it would fit into ABE

@dedmen
Copy link
Contributor Author

dedmen commented Mar 10, 2019 •
edited
Loading

And the label is too comical for my taste. Can't we just copy the original label?

Commy wanted the banana :D Original label has the manufacturers address there.
Give me a text to write there, my creativity was at it's end.
The labels on the original are also perfectly centered I think? It's a machine printing them afterall.
Or do you mean not rotate the label but rotate the grenade in advanced throwing?
Yeah can do that. It was actually an accident that it's rotated so perfectly :D

@bux
Copy link
Member

bux commented Mar 10, 2019 •
edited
Loading

Commy wanted the banana

he is also raging about Sexual Transmitted Diseases, so i'm not sure what to make of this 😄

Centanex:
https://www.centanex.co.uk/assets/image/products/ctx9op.png

Rheinmetall

Those labels look more appropriate to me

@commy2
Copy link
Contributor

commy2 commented Mar 10, 2019

Keep the banana.

@alganthe
Copy link
Contributor

agreed bux, the Rheinmetall one looks nice.

@bovine3dom
Copy link
Contributor

The CTS 9-bang this is based on has the manufacturer's address where the banana is. The label already has all the details that the more sober military spec ones have.

One alternative would be safety instructions - you're not supposed to throw them at muddy ground as it can clog the vents and turn it into a rocket, for example.

I'd like to see the serial number being used, too. One number from the top and bottom just be needs to be blacked out.

@jokoho48
Copy link
Member

I like the idea of easter eggs in models/textures but they need to be hard to find. I think in close to all models I have done/ where done in my time have small easter eggs, but they are not so open and bland as this one. so when it would be smaller somewhere I am totally fine with it but that big, please no.

@dedmen
Copy link
Contributor Author

dedmen commented Mar 10, 2019

Could just move the banana to the bottom ^^

@alganthe
Copy link
Contributor

maybe use a friendlier banana, this one belongs in ABE.

@jonpas
Copy link
Member

jonpas commented Mar 10, 2019

Keep it realistic as possible with small hard to find easter eggs. This is what ACE3 is about after-all.

@TheMagnetar
Copy link
Member

+1 on Rheinmetall

@dedmen
Copy link
Contributor Author

dedmen commented Mar 16, 2019 •
edited
Loading

arma3_x64_2019-03-16_12-49-09

That's 20° rotated now.

arma3_x64_2019-03-16_12-50-17

@bux
Copy link
Member

bux commented Mar 16, 2019

Do not peal peel

@commy2
Copy link
Contributor

commy2 commented Mar 16, 2019

You probably shouldn't use a grenade to peal either.

@dedmen
Copy link
Contributor Author

dedmen commented Mar 16, 2019


The triangle on the top is not visible ingame. Only on the screenshot :D

@jokoho48
Copy link
Member

I don't like the "made by dedmen" text there that breaks it I think again and I don't think any other model in ace currently has that type of marking by the model maker.

@dedmen
Copy link
Contributor Author

dedmen commented Mar 16, 2019

that breaks it I think again

?

I don't think any other model in ace currently has that type of marking

I guess none of the other ace models say "Made in ..." on the original then?

@jokoho48
Copy link
Member

I guess none of the other ace models say "Made in ..." on the original then?

maybe there are some but then the creator did not put there name in there but did things like "Made on Altis" or "Made in Greece" or maybe even "Made in ..." where ever it does get made

@commy2
Copy link
Contributor

commy2 commented May 4, 2019

Is this done apart from merging the branch that implements the scripting support for it?
I'd like to finish that branch and then also merge this.

@dedmen
Copy link
Contributor Author

dedmen commented May 4, 2019

If nothing changed on the config-entry syntax since it was pushed into here then yeah done.

@bux
Copy link
Member

bux commented May 7, 2019

Did you remove the "Made by dedmen"?

@dedmen
Copy link
Contributor Author

dedmen commented May 7, 2019

Did you remove the "Made by dedmen"?

no

@jonpas
Copy link
Member

jonpas commented Aug 5, 2019

Did you remove the "Made by dedmen"?

That'll have to be done before merge, name does not fit, write what's on the actual thing but modified for Arma.

@dedmen
Copy link
Contributor Author

dedmen commented Aug 6, 2019 •
edited
Loading

write what's on the actual thing

Actual thing says "Made in U.S.A."

@dedmen @bovine3dom
Update addons/grenades/CfgAmmo.hpp
15e6ad4 
Co-Authored-By: Oliver Blanthorn <[email protected]>
@jonpas
Copy link
Member

jonpas commented Aug 6, 2019

Then use that or a deviation such as "Made in Greece".

@bux
Copy link
Member

bux commented Nov 11, 2019 •
edited
Loading

Can we get that finished for 3.13?

@dedmen
Copy link
Contributor Author

dedmen commented Nov 12, 2019

Not sure. Please someone poke me on slack on Friday evening/weekend. I keep forgetting about this.

@dedmen dedmen changed the title WIP: Add CTS 7290 9-bang flashbang grenade Add CTS 7290 9-bang flashbang grenade Nov 18, 2019
@dedmen
Copy link
Contributor Author

dedmen commented Nov 18, 2019

MADE IN RASMAN

now says "dedmen <3" on bottom

@jonpas
Copy link
Member

jonpas commented Nov 23, 2019

What/Where is RASMAN?

now says "dedmen <3" on bottom

Why? Please remove. Banana references are fine, personal ego boosters are not.

@jokoho48
Copy link
Member

jokoho48 commented Nov 23, 2019 •
edited
Loading

What/Where is RASMAN?

RASMAN is the Northern city on Takistan, with the Airfield

@jonpas
Copy link
Member

jonpas commented Dec 7, 2019

now says "dedmen <3" on bottom
Why? Please remove. Banana references are fine, personal ego boosters are not.

Do so and we can merge it.

@PabstMirror PabstMirror changed the title Add CTS 7290 9-bang flashbang grenade Grenades - Add CTS 7290 9-bang flashbang Dec 17, 2019
@PabstMirror PabstMirror merged commit 60a901b into acemod:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 left review comments

@bovine3dom bovine3dom bovine3dom requested changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
9 participants
@dedmen @bux @commy2 @alganthe @bovine3dom @jokoho48 @jonpas @TheMagnetar @PabstMirror