Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo - Add condition checking during load/unload #6821

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Cargo - Add condition checking during load/unload #6821

merged 1 commit into from
Feb 23, 2019

Conversation

PabstMirror
Copy link
Contributor

Fix:
Car could drive off during loading and progress bar would continue
Showed load actions for blownup/dead vehicles

postInit - use findIf
addCargoVehiclesActions - check alive and not locked
startLoadIn/startUnload - add checks during progressBar

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Feb 17, 2019
@PabstMirror PabstMirror added this to the 3.13.0 milestone Feb 17, 2019
@PabstMirror PabstMirror changed the title Cargo - Add condition checking durring load/unload Cargo - Add condition checking during load/unload Feb 17, 2019
@bux
Copy link
Member

bux commented Feb 18, 2019

Could all those requirements be moved to a separate function?
They get repeated more than once.

@PabstMirror
Copy link
Contributor Author

it's similar to FUNC(canUnloadItem) but that also checks find unloadPos which is expensive

@severgun
Copy link
Contributor

severgun commented Feb 18, 2019 •
edited
Loading

Repair need same checks. You can dismount wheel on the go. Works better than rpg :D

@PabstMirror PabstMirror merged commit ec840a7 into master Feb 23, 2019
@PabstMirror PabstMirror deleted the cargoProgressbarConditions branch February 23, 2019 00:54
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.6 Feb 23, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@PabstMirror
Cargo - Add condition checking durring load/unload (#6821)
9883f34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.12.6
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @bux @severgun @jonpas